samarthjain commented on a change in pull request #7088: Improve parallelism of 
zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r277422795
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java
 ##########
 @@ -172,16 +170,15 @@ public void dropSegment(
       final LoadPeonCallback callback
   )
   {
-    final SegmentHolder existingHolder = segmentsToDrop.get(segment);
+    SegmentHolder segmentHolder = new SegmentHolder(segment, DROP, 
Collections.singletonList(callback));
+    final SegmentHolder existingHolder = segmentsToDrop.put(segment, 
segmentHolder);
 
 Review comment:
   Good catch. That was a miss.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to