leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final
Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590033
##########
File path:
extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplierTest.java
##########
@@ -51,6 +51,7 @@
import java.util.Set;
import java.util.stream.Collectors;
+@SuppressWarnings("SSBasedInspection") // static field(s) cannot be final
because not initialized in constructor
Review comment:
I don't understand what does this comment mean. Besides, I think all fields
starting from `recordsPerFetch` actually don't need to be static in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
