leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335582594
########## File path: core/src/main/java/org/apache/druid/common/config/NullHandling.java ########## @@ -50,6 +50,7 @@ * It does not take effect in all unit tests since we don't use Guice Injection. */ @Inject + @SuppressWarnings("SSBasedInspection") // static field(s) cannot be final because set in an initializer block Review comment: Again, has nothing to do with an initializer block. In this case, it's because this field is injected it cannot be final. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org