leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final 
Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595130
 
 

 ##########
 File path: 
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLifecycleTest.java
 ##########
 @@ -250,6 +250,7 @@ public int compare(DataSegment dataSegment, DataSegment 
dataSegment2)
   private SegmentHandoffNotifierFactory handoffNotifierFactory;
   private Map<SegmentDescriptor, Pair<Executor, Runnable>> handOffCallbacks;
 
+  @SuppressWarnings("SSBasedInspection") // static field(s) cannot be final 
because set in an initializer block
   private static CountDownLatch publishCountDown;
 
 Review comment:
   This field doesn't need to be static.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to