leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335604366
########## File path: processing/src/test/java/org/apache/druid/segment/SchemalessIndexTest.java ########## @@ -64,9 +64,10 @@ /** */ +@SuppressWarnings("SSBasedInspection") // static field(s) cannot be final because set in an static method Review comment: `mergedIndex` doesn't need to be static. It seems to be that `index` doesn't need to be static, too. `getIncrementalIndex()` and `makeIncrementalIndex()` should become non-static, too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org