jnaous commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r365296390
##########
File path:
processing/src/main/java/org/apache/druid/segment/VirtualColumns.java
##########
@@ -226,6 +238,7 @@ public DimensionSelector
makeDimensionSelector(DimensionSpec dimensionSpec, Colu
}
}
+ @Nullable
Review comment:
I assume this always sometimes returned null... If you do add optional
above, consider using optional here. Probably best left to another PR though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
