jnaous commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r365295725
##########
File path:
processing/src/main/java/org/apache/druid/segment/VirtualColumns.java
##########
@@ -180,11 +181,18 @@ public BitmapIndex getBitmapIndex(String columnName,
ColumnSelector columnSelect
if (virtualColumn == null) {
throw new IAE("No such virtual column[%s]", columnName);
} else {
- return virtualColumn.capabilities(columnName).hasBitmapIndexes() ?
virtualColumn.getBitmapIndex(columnName, columnSelector) : null;
+ return virtualColumn.capabilities(columnName).hasBitmapIndexes() ?
virtualColumn.getBitmapIndex(
+ columnName,
+ columnSelector
+ ) : null;
Review comment:
Same q as before around using Optional rather than null...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
