jnaous commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r365272114
##########
File path:
processing/src/main/java/org/apache/druid/query/extraction/MapLookupExtractor.java
##########
@@ -122,6 +122,18 @@ public boolean isOneToOne()
}
}
+ @Override
+ public boolean canIterate()
+ {
+ return true;
+ }
+
+ @Override
+ public Iterable<Map.Entry<String, String>> iterable()
+ {
+ return map.entrySet();
+ }
+
Review comment:
IMHO, these methods need unit tests to ensure maintainability and that
people don't inadvertently change the logic to be incorrect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
