jnaous commented on a change in pull request #9111: Add HashJoinSegment, a
virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#discussion_r365274511
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/vector/VectorValueMatcherColumnProcessorFactory.java
##########
@@ -19,55 +19,55 @@
package org.apache.druid.query.filter.vector;
-import org.apache.druid.query.dimension.VectorColumnStrategizer;
+import org.apache.druid.query.dimension.VectorColumnProcessorFactory;
import org.apache.druid.segment.vector.MultiValueDimensionVectorSelector;
import org.apache.druid.segment.vector.SingleValueDimensionVectorSelector;
import org.apache.druid.segment.vector.VectorValueSelector;
-public class VectorValueMatcherColumnStrategizer implements
VectorColumnStrategizer<VectorValueMatcherFactory>
+public class VectorValueMatcherColumnProcessorFactory implements
VectorColumnProcessorFactory<VectorValueMatcherFactory>
{
- private static final VectorValueMatcherColumnStrategizer INSTANCE = new
VectorValueMatcherColumnStrategizer();
+ private static final VectorValueMatcherColumnProcessorFactory INSTANCE = new
VectorValueMatcherColumnProcessorFactory();
Review comment:
I wish this were a singleton created by Guice... The other thing I really
hate other than type-checking in Java is static objects, even if final. They
make unit testing super hard because they force state to be reused (the state
within the static object, so we would have to be diligent about making the
object stateless), and they're harder to mock. Anyway, not the point of this
PR...
That said, this refactoring probably belongs in a separate PR. I think you
get the point, so I won't make these comments anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
