gianm commented on a change in pull request #9287: Add getRightColumns to
JoinConditionAnalysis
URL: https://github.com/apache/druid/pull/9287#discussion_r372598548
##########
File path:
processing/src/test/java/org/apache/druid/segment/join/JoinConditionAnalysisTest.java
##########
@@ -271,7 +283,7 @@ public void test_equals()
// These fields are tightly coupled with
originalExpression
"equiConditions", "nonEquiConditions",
// These fields are calculated from nonEquiConditions
- "isAlwaysTrue", "isAlwaysFalse", "canHashJoin")
+ "isAlwaysTrue", "isAlwaysFalse", "canHashJoin",
"rightKeyColumns")
Review comment:
The comment above is incorrect now. Actually, it was incorrect before too,
since some of these fields are based on equiConditions as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
