gianm commented on a change in pull request #9287: Add getRightColumns to
JoinConditionAnalysis
URL: https://github.com/apache/druid/pull/9287#discussion_r372599030
##########
File path:
server/src/main/java/org/apache/druid/segment/join/InlineJoinableFactory.java
##########
@@ -39,8 +38,7 @@
{
if (condition.canHashJoin() && dataSource instanceof InlineDataSource) {
final InlineDataSource inlineDataSource = (InlineDataSource) dataSource;
- final List<String> rightKeyColumns =
-
condition.getEquiConditions().stream().map(Equality::getRightColumn).distinct().collect(Collectors.toList());
+ final List<String> rightKeyColumns = condition.getRightKeyColumns();
Review comment:
You could probably do a similar simplification in LookupJoinMatcher (there's
a part that checks that all the equikeys are the key column).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
