suneet-s commented on a change in pull request #9287: Add getRightColumns to
JoinConditionAnalysis
URL: https://github.com/apache/druid/pull/9287#discussion_r372694314
##########
File path:
processing/src/test/java/org/apache/druid/segment/join/JoinConditionAnalysisTest.java
##########
@@ -60,6 +61,7 @@ public void test_forExpression_simple()
ImmutableList.of(),
exprsToStrings(analysis.getNonEquiConditions())
);
+ Assert.assertThat(analysis.getRightKeyColumns(),
CoreMatchers.is(ImmutableList.of("y")));
Review comment:
I definitely saw the test fail which is why I had to google how to fix this
- and I found CoreMatchers.
hahaha I think I know why now -
`Assert.assertEquals` checks `expected.equals(actual)`
`CoreMatchers.is` checks `actual.equals(expected)`
That probably means the equals implementation for one (or both?) of those
classes isn't correct according to the javadocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
