gianm commented on a change in pull request #9287: Add getRightColumns to
JoinConditionAnalysis
URL: https://github.com/apache/druid/pull/9287#discussion_r372597870
##########
File path:
processing/src/main/java/org/apache/druid/segment/join/JoinConditionAnalysis.java
##########
@@ -176,6 +179,14 @@ public boolean canHashJoin()
return canHashJoin;
}
+ /**
+ * Returns the distinct column keys from the RHS required to evaluate the
equi conditions.
+ */
+ public List<String> getRightKeyColumns()
+ {
Review comment:
I'm not sure if it's clear that this method only applies to the
equi-conditions. The javadoc explains it but the method name might be
misleading? What do you think?
I don't know if I have a good solution, btw.
`getRightKeyColumnsForEquiConditions` is clear but quite a mouthful. Maybe
`getRightEquiConditionKeys`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
