clintropolis commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r472478490



##########
File path: 
processing/src/main/java/org/apache/druid/query/aggregation/PostAggregator.java
##########
@@ -43,6 +45,13 @@
   @Nullable
   String getName();
 
+  String getTypeName();

Review comment:
       I have removed `typeName` from `PostAggregators` since it isn't 
necessary.
   
   Between the changes here, changes in #10277, and some other recent changes I 
have made, it is almost starting to look to me that perhaps aggs and postaggs 
should just consider supplying `ColumnCapabilities` of their own instead of 
just types, but I'll save that for future consideration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to