clintropolis commented on a change in pull request #9638: URL: https://github.com/apache/druid/pull/9638#discussion_r472549566
########## File path: core/src/main/java/org/apache/druid/segment/column/ValueType.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.column; + +import com.fasterxml.jackson.annotation.JsonCreator; +import org.apache.druid.java.util.common.StringUtils; + +import javax.annotation.Nullable; + +public enum ValueType +{ + DOUBLE, + FLOAT, + LONG, + STRING, + COMPLEX, + DOUBLE_ARRAY, + LONG_ARRAY, + STRING_ARRAY; Review comment: I am still working on javadocs here and other modified places to provide guidance on how types are and should be used, and how to deal with array types until they are fully propagated through the codebase. With regards to `COMPLEX`, I'm starting to think that in the future we might want to modify `RowSignature` to potentially have the ability to store the complex type name, similar to what is available for aggregator factory, and what #10277 adds to the `ColumnCapabilities` of complex type columns it creates. We might actually want a lighter weight `ColumnSignature` type that is a subset of `ColumnCapabilities` that `RowSignature` can be composed of, rather than it's strict `ValueType` mapping it currently has, but I'm not certain if it is necessary yet. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
