clintropolis commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r473436443
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/ExpressionPostAggregator.java
##########
@@ -179,6 +169,14 @@ public String getName()
return name;
}
+ @Override
+ public ValueType getType()
+ {
+ // this is wrong, replace with Expr output type based on the input types
once it is available
+ // but treat as string for now
+ return ValueType.STRING;
Review comment:
Also i did not explicitly change the output contract of
`PostAggregator.getType` to `@Nullable`, because I don't think that long term
it should be allowed to be that, but could change it to that for now while it
is true, and remove in the future once the expression post-agg knows its output
type.
Alternatively, I could have added an explicit output type json property,
similar to expression virtual column declaration, but I think we want to
deprecate those once output type inference is in place, so decided not to do
this at this time, but am open to including it if anyone thinks it is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
