clintropolis commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r472490006
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java
##########
@@ -210,22 +212,36 @@ public AggregatorFactory
getMergingFactory(AggregatorFactory other) throws Aggre
public abstract List<String> requiredFields();
/**
- * Get the type name of the intermediate type for this aggregator. This is
the same as the type returned by
+ * Get the "intermediate" {@link ValueType} for this aggregator. This is the
same as the type returned by
* {@link #deserialize} and the type accepted by {@link #combine}. However,
it is *not* necessarily the same type
* returned by {@link #finalizeComputation}.
+ */
+ public abstract ValueType getType();
+
+ /**
+ * Get the type for the final form of this this aggregator, i.e. the type of
the value returned by
+ * {@link #finalizeComputation}. This may be the same as or different than
the types expected in {@link #deserialize}
+ * and {@link #combine}.
+ * @return
+ */
+ public ValueType getFinalizedType()
+ {
+ return getType();
+ }
+
+ /**
+ * Get the complex type name of the intermediate type for this aggregator.
*
- * If the type is complex (i.e. not a simple, numeric {@link
org.apache.druid.segment.column.ValueType}) then there
+ * This should ONLY be implemented if the type is complex (i.e. not a
simple, numeric {@link ValueType}), and there
* must be a corresponding {@link
org.apache.druid.segment.serde.ComplexMetricSerde} which was registered with
* {@link org.apache.druid.segment.serde.ComplexMetrics#registerSerde} using
this type name.
*
- * If you need a ValueType enum corresponding to this aggregator, a good way
to do that is:
- *
- * <pre>
- * Optional.ofNullable(GuavaUtils.getEnumIfPresent(ValueType.class,
aggregator.getTypeName()))
- * .orElse(ValueType.COMPLEX);
- * </pre>
+ * If you need a ValueType enum corresponding to this aggregator, use {@link
#getTypeName} instead.
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
