clintropolis commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r476257505
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/ExpressionPostAggregator.java
##########
@@ -179,6 +169,14 @@ public String getName()
return name;
}
+ @Override
+ public ValueType getType()
+ {
+ // this is wrong, replace with Expr output type based on the input types
once it is available
+ // but treat as string for now
+ return ValueType.STRING;
Review comment:
Ah, I did end up adding it as `@Nullable`, I forgot to update this
comment. It is missing the note on it maybe not being like that in the future,
can add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
