clintropolis commented on a change in pull request #9638:
URL: https://github.com/apache/druid/pull/9638#discussion_r475796053
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/post/FinalizingFieldAccessPostAggregator.java
##########
@@ -26,16 +26,20 @@
import org.apache.druid.query.aggregation.AggregatorFactory;
import org.apache.druid.query.aggregation.PostAggregator;
import org.apache.druid.query.cache.CacheKeyBuilder;
+import org.apache.druid.segment.column.ValueType;
+import org.apache.druid.segment.column.ValueTypes;
import java.util.Comparator;
import java.util.Map;
+import java.util.Objects;
import java.util.Set;
import java.util.function.Function;
public class FinalizingFieldAccessPostAggregator implements PostAggregator
{
private final String name;
private final String fieldName;
+ private final ValueType finalizedType;
Review comment:
Hmm, I'm undecided if it should it be in equals and hashCode... Should
calling `decorate` still be equal to the postagg before calling decorate? If
so, then I think it should be ignored in these places since the value is
computed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
