clintropolis commented on a change in pull request #9638: URL: https://github.com/apache/druid/pull/9638#discussion_r473438018
########## File path: core/src/main/java/org/apache/druid/segment/column/ValueType.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.column; + +import com.fasterxml.jackson.annotation.JsonCreator; +import org.apache.druid.java.util.common.StringUtils; + +import javax.annotation.Nullable; + +public enum ValueType +{ + DOUBLE, + FLOAT, + LONG, + STRING, + COMPLEX, + DOUBLE_ARRAY, + LONG_ARRAY, + STRING_ARRAY; Review comment: I've added a bunch of javadocs trying to advise on what each ValueType represents and how it may be used in the query engines, I hope it is sufficient to provide guidance for complex type/agg/post-agg implementors to think about how the thing is going to be used, but I'm sure that I'm probably leaving out a lot of details, and it might be somewhat brittle to keep in sync with reality as the engines evolve. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
