harinirajendran commented on a change in pull request #11417:
URL: https://github.com/apache/druid/pull/11417#discussion_r667144433
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -3658,6 +3665,25 @@ private boolean checkOffsetAvailability(
&&
makeSequenceNumber(earliestOffset).compareTo(makeSequenceNumber(offsetFromMetadata))
<= 0;
}
+ protected void emitNoticesQueueSize()
+ {
+ if (spec.isSuspended() || !stateManager.isSteadyState()) {
+ // don't emit metrics if supervisor is suspended or not in a healthy
running state
+ // (lag should still available in status report)
Review comment:
>seems to be copy-pasta from emitLag()
That's right. I'll remove it.
> would it still make sense to keep emitting queue size if the supervisor is
not in steady state?
that sounds reasonable. I was just trying to follow the same pattern that
was used for emitLag. Will update the code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
