xvrl commented on a change in pull request #11417:
URL: https://github.com/apache/druid/pull/11417#discussion_r668345347
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
##########
@@ -908,7 +908,9 @@ public void tryInit()
notice.handle();
Instant handleNoticeEndTime = Instant.now();
Duration timeElapsed =
Duration.between(handleNoticeStartTime, handleNoticeEndTime);
- log.debug("Handled notice [%s] from notices queue in [%d]
ms, current notices queue size [%d]", notice.getClass().getName(),
timeElapsed.toMillis(), getNoticesQueueSize());
+ String noticeType = notice.getClass().getName();
Review comment:
instead of relying on the class name, which could change, I would
suggest we use constants like we do in `Task.getType()`. This also ensures the
dimension values are consistently formatted (I believe the convention is
`lowercase` or `snake_lowercase` for most of our metric dimensions) rather than
adding a new convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
