xvrl commented on a change in pull request #11417:
URL: https://github.com/apache/druid/pull/11417#discussion_r667177603
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java
##########
@@ -1214,16 +1248,19 @@ public LagStats computeLagStats()
private final CountDownLatch latch;
private final Map<String, Long> partitionsRecordLag;
private final Map<String, Long> partitionsTimeLag;
+ private boolean emitNoticeQueueSize;
TestEmittingTestSeekableStreamSupervisor(
CountDownLatch latch,
Map<String, Long> partitionsRecordLag,
- Map<String, Long> partitionsTimeLag
+ Map<String, Long> partitionsTimeLag,
+ boolean emitNoticeQueueSize
Review comment:
it's a little awkward to have this flag. I think it would nicer to
update the existing tests to ignore metrics unrelated to what they are testing.
This will make it easier to add new metrics in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
