harinirajendran commented on a change in pull request #11417:
URL: https://github.com/apache/druid/pull/11417#discussion_r667145690
##########
File path:
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java
##########
@@ -1214,16 +1248,19 @@ public LagStats computeLagStats()
private final CountDownLatch latch;
private final Map<String, Long> partitionsRecordLag;
private final Map<String, Long> partitionsTimeLag;
+ private boolean emitNoticeQueueSize;
TestEmittingTestSeekableStreamSupervisor(
CountDownLatch latch,
Map<String, Long> partitionsRecordLag,
- Map<String, Long> partitionsTimeLag
+ Map<String, Long> partitionsTimeLag,
+ boolean emitNoticeQueueSize
Review comment:
Because I didn't want to mix up the tests that are testing the emitlag
logic by emitting noticesQueue size metric. So explicitly disabling it in all
lag related tests and added a separate test for this new metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
