gianm commented on code in PR #16790:
URL: https://github.com/apache/druid/pull/16790#discussion_r1695632629
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/worker/WorkerStagePhase.java:
##########
@@ -54,11 +54,12 @@ public boolean canTransitionFrom(final WorkerStagePhase
priorPhase)
@Override
public boolean canTransitionFrom(final WorkerStagePhase priorPhase)
{
- return priorPhase == PRESHUFFLE_WAITING_FOR_RESULT_PARTITION_BOUNDARIES;
+ return priorPhase == PRESHUFFLE_WAITING_FOR_RESULT_PARTITION_BOUNDARIES
/* if globally sorting */
+ || priorPhase == READING_INPUT /* if locally sorting */;
Review Comment:
Before this patch, stages that locally sort would not enter the
`PRESHUFFLE_WRITING_OUTPUT` phase. They would go directly from `READING_INPUT`
to `RESULTS_READY`. But now, they need to enter `PRESHUFFLE_WRITING_OUTPUT` so
they can send `doneReadingInput` to the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
