gianm commented on code in PR #16790: URL: https://github.com/apache/druid/pull/16790#discussion_r1696290080
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/output/StageOutputReader.java: ########## Review Comment: Ah, the `OutputChannel` class naming has come up before as being confusing. IMO, if we're going to change the name of something, it should be that class. When it has a writable + readable channel pair, it's really more like a "channel pair" or a "pipe". Maybe it'd make sense to change that to `OutputPipe` in a follow-up, and have the `readOnly()` method return `List<ReadableFrameChannel>`? At any rate, I don't think we need to let the funny naming of that class affect how we name this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
