gianm commented on code in PR #16790: URL: https://github.com/apache/druid/pull/16790#discussion_r1695664534
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerMemoryParameters.java: ########## Review Comment: > Since we use maxConcurrentStages in the memory parameters, I wonder if it should be the maxConcurrentStages that the user passes (present code), or if it should be the maximum concurrent stages that can happen given the query structure. For example, if each stage sorts in the query, the maximum concurrent stages that can happen = 1, however, if the user passes it as 10, we would be allocating less memory per stage even though it isn't required. That would be a useful optimization for a future patch, imo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
