gianm commented on code in PR #16790:
URL: https://github.com/apache/druid/pull/16790#discussion_r1695636213
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestWorkerClient.java:
##########
@@ -138,12 +133,11 @@ public ListenableFuture<Boolean> fetchChannelData(
catch (Exception e) {
throw new ISE(e, "Error reading frame file channel");
}
-
}
@Override
public void close()
{
- inMemoryWorkers.forEach((k, v) -> v.stopGracefully());
+ inMemoryWorkers.forEach((k, v) -> v.stop());
Review Comment:
I thought that `stopGracefully` was not really an appropriate method name to
have on `Worker`. It's too linked to the behavior of tasks, and I wanted to
make the `Worker` interface more easily extensible to workers that aren't tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
