susiwen8 opened a new pull request, #21597:
URL: https://github.com/apache/echarts/pull/21597

   ## Summary
   
   - Add `label.rotate: 'radial'` support for chord node labels.
   - Keep numeric chord `label.rotate` working by applying degree-to-radian 
conversion in the chord label layout path.
   - Add a regression test that verifies rendered chord node text receives the 
expected radial rotation.
   
   Fixes #21199.
   
   ## Screenshot
   
   ![Chord radial labels 
demo](https://raw.githubusercontent.com/apache/echarts/codex-issue-21199-radial-label-preview/chord-radial-demo.png)
   
   ## Validation
   
   - `npx jest --config test/ut/jest.config.cjs --runTestsByPath 
test/ut/spec/series/chord.test.ts --coverage=false`
   - `npm test -- --runInBand --coverage=false`
   - `npm run checktype`
   - `npm run lint -- --no-cache src/chart/chord/ChordPiece.ts 
src/chart/chord/ChordSeries.ts`
   - `npx eslint --no-cache test/ut/spec/series/chord.test.ts`
   - `npx tsc -p test/ut/tsconfig.json --noEmit --moduleResolution node 
--skipLibCheck`
   
   ## Note
   
   `npm run checkheader` currently fails on pre-existing files outside this 
change (`test/ut/coverage/*`, `test/line-area-empty-dimension-name.html`, and 
`test/visualmap-seriesTargets.html`). The files changed in this PR have license 
headers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to