susiwen8 commented on code in PR #21597:
URL: https://github.com/apache/echarts/pull/21597#discussion_r3176033965
##########
src/chart/chord/ChordSeries.ts:
##########
@@ -97,9 +97,10 @@ export interface ChordEdgeLineStyleOption extends
LineStyleOption {
curveness?: number
}
-export interface ChordNodeLabelOption extends
Omit<SeriesLabelOption<CallbackDataParams>, 'position'> {
+export interface ChordNodeLabelOption extends
Omit<SeriesLabelOption<CallbackDataParams>, 'position' | 'rotate'> {
silent?: boolean
position?: SeriesLabelOption['position'] | 'outside'
+ rotate?: number | 'radial'
Review Comment:
Addressed in b022a719f by using ChordNodeLabelOption for chord state labels,
so emphasis/blur/select labels accept rotate: radial consistently.
##########
test/ut/spec/series/chord.test.ts:
##########
@@ -0,0 +1,68 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements. See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership. The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
+* software distributed under the License is distributed on an
+* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+* KIND, either express or implied. See the License for the
+* specific language governing permissions and limitations
+* under the License.
+*/
+
+import { EChartsType } from '@/src/echarts';
+import ChordSeriesModel from '@/src/chart/chord/ChordSeries';
+import { createChart, getECModel } from '../../core/utHelper';
+
+describe('series/chord', function () {
+
+ let chart: EChartsType;
+
+ beforeEach(function () {
+ chart = createChart();
+ });
+
+ afterEach(function () {
+ chart.dispose();
+ });
+
+ it('supports radial label rotation', function () {
+ chart.setOption({
+ series: {
+ type: 'chord',
+ startAngle: 0,
+ padAngle: 0,
+ label: {
+ show: true,
+ rotate: 'radial'
+ },
Review Comment:
Addressed in b022a719f by adding a numeric rotation regression case that
verifies 45 degrees maps to Math.PI / 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
