Copilot commented on code in PR #21597:
URL: https://github.com/apache/echarts/pull/21597#discussion_r3176036042
##########
src/chart/chord/ChordPiece.ts:
##########
@@ -174,15 +176,23 @@ export default class ChordPiece extends graphic.Sector {
? normalLabelModel.get('verticalAlign') || 'middle'
: (dy > 0 ? 'top' : 'bottom');
+ let labelRotate = 0;
+ const rotate = normalLabelModel.get('rotate');
+ if (rotate === 'radial') {
+ labelRotate = dx < 0 ? -midAngle + Math.PI : -midAngle;
+ }
+ else if (isNumber(rotate)) {
+ labelRotate = rotate * RADIAN;
+ }
Review Comment:
`label.rotate` is only read from the normal label model here. Because chord
labels are rendered as a standalone `Text`, `setLabelStyle` does not propagate
rotation into the emphasis/blur/select states, so the newly typed
`emphasis.label.rotate` / `blur.label.rotate` / `select.label.rotate` options
still have no effect at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
