malinjawi commented on PR #12036: URL: https://github.com/apache/gluten/pull/12036#issuecomment-4378925301
Addressed Felix's request and the parser-suite CI failure. Changes pushed: - Added a generated `Status` column to `docs/velox-configuration.md`, using `⚓ Static` / `🔄 Dynamic` from Spark's `SQLConf.isStaticConfigKey` source of truth. - Updated the Spark 4.0/4.1 `GlutenSparkSqlParserSuite` wrappers to keep the `SET/RESET` config parser coverage, but quote config keys. This fixes the failure on registered Gluten keys such as `spark.gluten.soft-affinity.logLevel`. Local verification: - `GLUTEN_UPDATE=1 ./build/mvn test -Pbackends-velox -pl backends-velox -am -Dtest=none -DfailIfNoTests=false -DwildcardSuites=org.apache.gluten.config.AllVeloxConfiguration` - `./dev/run-scala-test.sh -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/spark40 -s org.apache.spark.sql.execution.GlutenSparkSqlParserSuite` - `./dev/run-scala-test.sh -Pjava-17,spark-4.1,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/spark41 -s org.apache.spark.sql.execution.GlutenSparkSqlParserSuite` - `./build/mvn test-compile -Pjava-17,spark-3.5,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/spark35 -am` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
