malinjawi commented on PR #12036: URL: https://github.com/apache/gluten/pull/12036#issuecomment-4449825254
Thanks @philo-he, addressed both comments in `1a83774d8`. Changes: - Removed the parser-suite `test(...)` override. The original Spark `Checks if SET/RESET can parse all the configurations` case is now excluded in `VeloxTestSettings.scala`, and the quoted-key Gluten variant is registered normally with `testGluten(...)`. - Moved the two Gluten runtime config tests into a new shared suite under `gluten-ut/test`: `org.apache.gluten.config.GlutenRuntimeConfigSuite`. - Restored the Spark 4.0 / 4.1 `GlutenRuntimeConfigSuite` files to version-specific wrappers around Spark's original `RuntimeConfigSuite`. Verified locally: - `./dev/format-scala-code.sh check` - `./build/mvn test-compile -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/spark40 -am` - `./build/mvn test-compile -Pjava-17,spark-4.1,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/spark41 -am` - `./dev/run-scala-test.sh -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/test -s org.apache.gluten.config.GlutenRuntimeConfigSuite` - `./dev/run-scala-test.sh -Pjava-17,spark-4.1,scala-2.13,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/test -s org.apache.gluten.config.GlutenRuntimeConfigSuite` - `./dev/run-scala-test.sh -Pjava-17,spark-3.5,scala-2.12,backends-velox,hadoop-3.3,spark-ut -pl gluten-ut/test -s org.apache.gluten.config.GlutenRuntimeConfigSuite` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
