philo-he commented on code in PR #12036:
URL: https://github.com/apache/gluten/pull/12036#discussion_r3239276390
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenSparkSqlParserSuite.scala:
##########
@@ -18,4 +18,37 @@ package org.apache.spark.sql.execution
import org.apache.spark.sql.GlutenSQLTestsBaseTrait
-class GlutenSparkSqlParserSuite extends SparkSqlParserSuite with
GlutenSQLTestsBaseTrait {}
+import org.scalactic.source.Position
+import org.scalatest.Tag
+
+class GlutenSparkSqlParserSuite extends SparkSqlParserSuite with
GlutenSQLTestsBaseTrait {
+ private var registerQuotedConfigParserTest = false
+
+ override protected def test(testName: String, testTags: Tag*)(testFun: =>
Any)(implicit
+ pos: Position): Unit = {
+ if (isConfigParserCoverage(testName) && !registerQuotedConfigParserTest) {
Review Comment:
Does this mean the original Spark test is excluded and replaced by the
variant test? If so, can we just exclude it in VeloxTestSettings.scala and let
the variant be tested instead?
```
testGluten("Checks if SET/RESET can parse all the configurations") {
}
```
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenRuntimeConfigSuite.scala:
##########
@@ -16,6 +16,28 @@
*/
package org.apache.spark.sql
+import org.apache.gluten.config.GlutenConfig
+
import org.apache.spark.sql.shim.GlutenTestsTrait
-class GlutenRuntimeConfigSuite extends RuntimeConfigSuite with
GlutenTestsTrait {}
+class GlutenRuntimeConfigSuite extends RuntimeConfigSuite with
GlutenTestsTrait {
+ test("Gluten configs report correct runtime modifiability") {
+ val conf = SparkSession.active.conf
+ assert(conf.isModifiable(GlutenConfig.COLUMNAR_FILESCAN_ENABLED.key))
+ assert(!conf.isModifiable(GlutenConfig.GLUTEN_UI_ENABLED.key))
+ }
+
+ test("GlutenConfig reads active SparkSession runtime configs") {
Review Comment:
Can we move these two tests to a new test suite under gluten-ut/test?
Generally, the spark{VERSION} folders are used for Spark's original tests and
their version-specific variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
