malinjawi commented on code in PR #12036:
URL: https://github.com/apache/gluten/pull/12036#discussion_r3241304675
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenRuntimeConfigSuite.scala:
##########
@@ -16,6 +16,28 @@
*/
package org.apache.spark.sql
+import org.apache.gluten.config.GlutenConfig
+
import org.apache.spark.sql.shim.GlutenTestsTrait
-class GlutenRuntimeConfigSuite extends RuntimeConfigSuite with
GlutenTestsTrait {}
+class GlutenRuntimeConfigSuite extends RuntimeConfigSuite with
GlutenTestsTrait {
+ test("Gluten configs report correct runtime modifiability") {
+ val conf = SparkSession.active.conf
+ assert(conf.isModifiable(GlutenConfig.COLUMNAR_FILESCAN_ENABLED.key))
+ assert(!conf.isModifiable(GlutenConfig.GLUTEN_UI_ENABLED.key))
+ }
+
+ test("GlutenConfig reads active SparkSession runtime configs") {
Review Comment:
Thanks @philo-he, moved these two Gluten-specific tests into a new shared
suite under `gluten-ut/test`:
`org.apache.gluten.config.GlutenRuntimeConfigSuite`.
I also restored the Spark 4.0 / 4.1 `GlutenRuntimeConfigSuite` files to only
wrap Spark's original `RuntimeConfigSuite`.
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenSparkSqlParserSuite.scala:
##########
@@ -18,4 +18,37 @@ package org.apache.spark.sql.execution
import org.apache.spark.sql.GlutenSQLTestsBaseTrait
-class GlutenSparkSqlParserSuite extends SparkSqlParserSuite with
GlutenSQLTestsBaseTrait {}
+import org.scalactic.source.Position
+import org.scalatest.Tag
+
+class GlutenSparkSqlParserSuite extends SparkSqlParserSuite with
GlutenSQLTestsBaseTrait {
+ private var registerQuotedConfigParserTest = false
+
+ override protected def test(testName: String, testTags: Tag*)(testFun: =>
Any)(implicit
+ pos: Position): Unit = {
+ if (isConfigParserCoverage(testName) && !registerQuotedConfigParserTest) {
Review Comment:
Thanks @philo-he, addressed. I removed the custom `test(...)` override,
excluded Spark's original `Checks if SET/RESET can parse all the
configurations` case in `VeloxTestSettings.scala`, and registered the
quoted-key coverage as a normal `testGluten(...)` variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
