Copilot commented on code in PR #12829: URL: https://github.com/apache/gluten/pull/12829#discussion_r3834496250
########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -190,9 +190,16 @@ list so it can't leak into the baseline): # regex matched against the failure message + stack (enforce mode). # one explicit pattern per known error, deliberately specific. Delta RoaringBitmapArray row index \d+ exceeds max representable value -Delta bitmap row index cannot be negative: -?\d+ +Delta bitmap row index cannot be negative: -\d+ ``` +That example is historical: the root cause was a Velox scan bug +([velox#18535](https://github.com/facebookincubator/velox/issues/18535)), fixed +by [velox#18536](https://github.com/facebookincubator/velox/pull/18536) and +picked up by the `dft-2026_08_21` Velox pin, so both patterns were removed and +the suite is enforced again. It is kept here because it shows the shape of the Review Comment: PR description says Gluten “currently pins dft-2026_08_17” and warns this must not merge before a Velox bump. In this branch, the pinned Velox branch is already `dft-2026_08_21` (see `ep/build-velox/src/get-velox.sh:21`). Please update the PR description / merge-block note so reviewers aren’t misled about whether it’s safe to drop the quarantines. ########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -190,9 +190,16 @@ list so it can't leak into the baseline): # regex matched against the failure message + stack (enforce mode). # one explicit pattern per known error, deliberately specific. Delta RoaringBitmapArray row index \d+ exceeds max representable value -Delta bitmap row index cannot be negative: -?\d+ +Delta bitmap row index cannot be negative: -\d+ Review Comment: The README still shows the two DV regex patterns inside a code block, but `flaky-error-patterns.txt` is now empty. Since the “historical” disclaimer comes after the block, it’s easy to skim and mistake these for the current active patterns. Adding an explicit “HISTORICAL example” marker inside the block would prevent accidental copy/paste. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
