felipepessoto commented on code in PR #12829: URL: https://github.com/apache/gluten/pull/12829#discussion_r3834510781
########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -193,6 +193,11 @@ Delta RoaringBitmapArray row index \d+ exceeds max representable value Delta bitmap row index cannot be negative: -?\d+ Review Comment: Good catch, fixed in `9fee7d0`. Confirmed against the file's history: the real pattern was `Delta bitmap row index cannot be negative: -\d+`, and it carried a comment explaining why — the check is `value >= 0`, so the reported index is always negative, and matching the sign explicitly keeps the pattern from quarantining an unrelated failure if the message format ever changes. The README example had drifted to `-?\d+`, contradicting both that pattern and the line right above it about patterns being deliberately specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
