felipepessoto commented on code in PR #12829: URL: https://github.com/apache/gluten/pull/12829#discussion_r3834511013
########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -193,6 +193,11 @@ Delta RoaringBitmapArray row index \d+ exceeds max representable value Delta bitmap row index cannot be negative: -?\d+ ``` +That example is historical: the root cause was a Velox scan bug +([velox#18535](https://github.com/facebookincubator/velox/issues/18535)), fixed +upstream, so both patterns have since been removed and the suite is enforced +again. It is kept here because it shows the shape of the mechanism. Review Comment: Partly taken, in `9fee7d0`: the note now names the fix and where it landed — [velox#18536](https://github.com/facebookincubator/velox/pull/18536), picked up by the `dft-2026_08_21` pin — rather than just saying "fixed upstream". I left the merge-gating wording out of the README on purpose. "Do not merge until the pin includes this commit" was a property of this PR at this moment, not a durable fact about the harness: pins only move forward, so a permanent "requires pin >= X" note would describe a condition that is already true and can never become false again. The dependency belongs in the PR description instead, where it is actionable — and it is now satisfied, since main pins `dft-2026_08_21` and this branch is rebased onto that bump. (Your other comment correctly notes the description still quotes the old pin; that is being corrected.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
