felipepessoto commented on code in PR #12829: URL: https://github.com/apache/gluten/pull/12829#discussion_r3834527317
########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -190,9 +190,16 @@ list so it can't leak into the baseline): # regex matched against the failure message + stack (enforce mode). # one explicit pattern per known error, deliberately specific. Delta RoaringBitmapArray row index \d+ exceeds max representable value -Delta bitmap row index cannot be negative: -?\d+ +Delta bitmap row index cannot be negative: -\d+ Review Comment: Fair point — fixed in `45de5eb8`. The marker now lives inside the code block, where it cannot be skimmed past: ``` # HISTORICAL EXAMPLE -- no longer active; flaky-error-patterns.txt has no # entries. Do not copy these back in: the bug they matched is fixed. ``` I also dropped the "That example is historical:" lead-in from the paragraph below, since the block now says so itself. ########## .github/workflows/util/delta-spark-ut/README.md: ########## @@ -190,9 +190,16 @@ list so it can't leak into the baseline): # regex matched against the failure message + stack (enforce mode). # one explicit pattern per known error, deliberately specific. Delta RoaringBitmapArray row index \d+ exceeds max representable value -Delta bitmap row index cannot be negative: -?\d+ +Delta bitmap row index cannot be negative: -\d+ ``` +That example is historical: the root cause was a Velox scan bug +([velox#18535](https://github.com/facebookincubator/velox/issues/18535)), fixed +by [velox#18536](https://github.com/facebookincubator/velox/pull/18536) and +picked up by the `dft-2026_08_21` Velox pin, so both patterns were removed and +the suite is enforced again. It is kept here because it shows the shape of the Review Comment: Agreed, and done — the description no longer claims the old pin or warns against merging. It now reads: > **Merge dependency — satisfied.** This needed the Velox pin to contain `1f971d3`. Gluten now pins `dft-2026_08_21`, which does, and this branch is rebased onto that bump, so the PR is ready to merge. One deliberate exception: `dft-2026_08_17` still appears once, in the opposite sense. This PR's first run went 8 of 8 green while building that tag, which does *not* contain the fix — a useful reminder that a green Delta suite proves nothing here, since the abort is intermittent. That sentence is meant to stay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
