Copilot commented on code in PR #12946:
URL: https://github.com/apache/gluten/pull/12946#discussion_r3902533997
##########
pom.xml:
##########
@@ -1909,7 +1909,7 @@
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
- <id>add-iceberg-test-sources</id>
+ <id>add-iceberg-spark-test-sources</id>
Review Comment:
The new execution ids include `spark`, but the PR description frames the
change as giving `iceberg-test` its own ids. To make the intent unambiguous
(and prevent future collisions), consider encoding the owning profile in the id
(e.g., suffix `-iceberg` vs `-iceberg-test`, or similar consistent scheme).
This makes it immediately clear *why* the ids differ and which profile owns
each execution.
##########
pom.xml:
##########
@@ -1922,7 +1922,7 @@
</configuration>
</execution>
<execution>
- <id>add-iceberg-test-resources</id>
+ <id>add-iceberg-spark-test-resources</id>
Review Comment:
The new execution ids include `spark`, but the PR description frames the
change as giving `iceberg-test` its own ids. To make the intent unambiguous
(and prevent future collisions), consider encoding the owning profile in the id
(e.g., suffix `-iceberg` vs `-iceberg-test`, or similar consistent scheme).
This makes it immediately clear *why* the ids differ and which profile owns
each execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
