LuciferYang commented on code in PR #12946:
URL: https://github.com/apache/gluten/pull/12946#discussion_r4178345238
##########
pom.xml:
##########
@@ -1880,8 +1880,12 @@
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
+ <!-- These ids must stay different from the iceberg profile's
+ add-iceberg-test-sources / add-iceberg-test-resources:
Maven merges plugin
+ executions by id, so sharing one would drop the other
profile's sources
+ whenever both profiles are active, which is how every
in-repo build runs. -->
<execution>
- <id>add-iceberg-test-sources</id>
+ <id>add-iceberg-spark-test-sources</id>
Review Comment:
`-Piceberg` is load-bearing there: the `src-iceberg-spark34/test` sources
that `-Piceberg-test` adds import `org.apache.gluten.TestConfUtil` from
`src-iceberg/main/java` and need the `gluten-iceberg` module and
`iceberg-spark-runtime`, all of which only `-Piceberg` supplies. Dropping it
would break test-compile for those three groups.
I also overstated the cost in the description. These three groups are Spark
3.4, and before this fix `VeloxIcebergSuite` / `VeloxTPCHIcebergSuite` never
ran on 3.4 at all (the collision dropped `src-iceberg/test`, and the 3.4 slow
jobs only run tagged suites). The `-Piceberg`-only runs at `:941` and `:1013`
are Spark 3.5. So the change adds 3.4 coverage for those two suites in group 1,
rather than running the same thing twice. I've corrected the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
