jackylee-ch commented on code in PR #12946:
URL: https://github.com/apache/gluten/pull/12946#discussion_r4173911113
##########
pom.xml:
##########
@@ -1880,8 +1880,12 @@
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
+ <!-- These ids must stay different from the iceberg profile's
+ add-iceberg-test-sources / add-iceberg-test-resources:
Maven merges plugin
+ executions by id, so sharing one would drop the other
profile's sources
+ whenever both profiles are active, which is how every
in-repo build runs. -->
<execution>
- <id>add-iceberg-test-sources</id>
+ <id>add-iceberg-spark-test-sources</id>
Review Comment:
With both sources executions now surviving, the three `velox_backend_x86`
groups that pass `-Piceberg -Piceberg-test` compile and run
`VeloxIcebergSuite`/`VeloxTPCHIcebergSuite` twice across the matrix (here, and
again in the `-Piceberg`-only jobs). You flagged this in the description and
kept `-Piceberg` to preserve dependency resolution — given the ongoing effort
to reduce the project's GHA usage, is the dependency difference from dropping
`-Piceberg` on those three commands actually load-bearing, or could we drop it
there to avoid the double run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
