LuciferYang commented on code in PR #12946:
URL: https://github.com/apache/gluten/pull/12946#discussion_r4143924700
##########
pom.xml:
##########
@@ -1909,7 +1909,7 @@
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
- <id>add-iceberg-test-sources</id>
+ <id>add-iceberg-spark-test-sources</id>
Review Comment:
The ids already differ from the `iceberg` profile's
`add-iceberg-test-sources` / `add-iceberg-test-resources`, which is exactly the
collision this PR fixes: Maven merges plugin executions by id, so a shared id
silently drops one profile's sources whenever both profiles are active (which
is how every in-repo build runs). The `spark` token marks these as the
spark-side iceberg test sources, and the inline comment documents why they must
stay distinct. Happy to switch to a specific naming scheme if you prefer one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
