n3nash commented on a change in pull request #600: Timeline Service with
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271918483
##########
File path:
hoodie-client/src/main/java/com/uber/hoodie/io/compact/HoodieRealtimeTableCompactor.java
##########
@@ -185,11 +184,10 @@ public HoodieCompactionPlan
generateCompactionPlan(JavaSparkContext jsc,
// filter the partition paths if needed to reduce list status
partitionPaths =
config.getCompactionStrategy().filterPartitionPaths(config, partitionPaths);
- TableFileSystemView.RealtimeView fileSystemView =
hoodieTable.getRTFileSystemView();
log.info("Compaction looking for files to compact in " + partitionPaths +
" partitions");
List<HoodieCompactionOperation> operations =
jsc.parallelize(partitionPaths, partitionPaths.size())
- .flatMap((FlatMapFunction<String, CompactionOperation>)
partitionPath -> fileSystemView
+ .flatMap((FlatMapFunction<String, CompactionOperation>)
partitionPath -> hoodieTable.getRTFileSystemView()
Review comment:
this sends the hoodie table to each executor, is that expected ? this means
a new FileSystemViewManager will be created every time on all executors since
you've made that transient in the hoodie table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services