n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271924427
########## File path: hoodie-common/src/main/java/com/uber/hoodie/common/model/HoodieLogFile.java ########## @@ -38,54 +38,72 @@ public static final String DELTA_EXTENSION = ".log"; public static final Integer LOGFILE_BASE_VERSION = 1; - private final Path path; - private Optional<FileStatus> fileStatus; + private FileStatus fileStatus; Review comment: this should also be final ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services