n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r271921122
########## File path: hoodie-client/src/test/java/com/uber/hoodie/TestAsyncCompactionWithEmbeddedTimelineServer.java ########## @@ -0,0 +1,55 @@ +/* + * Copyright (c) 2017 Uber Technologies, Inc. (hoodie-dev-gr...@uber.com) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * + */ + +package com.uber.hoodie; + +import com.uber.hoodie.common.table.HoodieTableMetaClient; +import com.uber.hoodie.common.table.HoodieView; +import com.uber.hoodie.common.table.view.FileSystemViewStorageConfig; +import com.uber.hoodie.common.table.view.FileSystemViewStorageType; +import com.uber.hoodie.config.HoodieWriteConfig; +import com.uber.hoodie.exception.HoodieException; +import com.uber.hoodie.table.HoodieTable; +import java.io.IOException; +import org.junit.After; + +public class TestAsyncCompactionWithEmbeddedTimelineServer extends TestAsyncCompaction { + + protected HoodieWriteConfig.Builder getConfigBuilder(Boolean autoCommit) { Review comment: Is this supposed to be overriding the method from TestAsyncCompaction to enable timeline server path ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
