n3nash commented on a change in pull request #600: Timeline Service with
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274224378
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
##########
@@ -215,7 +249,15 @@ public void clear() {
@Override
public Collection<R> values() {
- throw new HoodieException("Unsupported Operation Exception");
Review comment:
This is something that will result in OOMing of the process if allowed to
run, I don't think we should support this. I like the valueStream() that you
provided below..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
