n3nash commented on a change in pull request #600: Timeline Service with
Incremental View Syncing support
URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274223908
##########
File path:
hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
##########
@@ -74,6 +73,22 @@ protected DiskBasedMap(String baseFilePath) throws
IOException {
this.filePosition = new AtomicLong(0L);
}
+ /**
+ * RandomAcessFile is not thread-safe. This API opens a new file handle and
returns.
+ * @return
+ */
+ private RandomAccessFile getNewRandomAccessFile() {
Review comment:
Instead of this, can we just create a synchronized version of the
RandomAccessFile ? Wrap the class and implement 1 writer-N readers model, just
like something discussed above for AbstractFileSystem..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
