n3nash commented on a change in pull request #600: Timeline Service with Incremental View Syncing support URL: https://github.com/apache/incubator-hudi/pull/600#discussion_r274221885
########## File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/view/PriorityBasedFileSystemViewDelegator.java ########## @@ -0,0 +1,238 @@ +/* + * Copyright (c) 2018 Uber Technologies, Inc. (hoodie-dev-gr...@uber.com) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.uber.hoodie.common.table.view; + +import com.uber.hoodie.common.model.CompactionOperation; +import com.uber.hoodie.common.model.FileSlice; +import com.uber.hoodie.common.model.HoodieDataFile; +import com.uber.hoodie.common.model.HoodieFileGroup; +import com.uber.hoodie.common.table.HoodieTimeline; +import com.uber.hoodie.common.table.HoodieView; +import com.uber.hoodie.common.table.timeline.HoodieInstant; +import com.uber.hoodie.common.util.Functions.Function0; +import com.uber.hoodie.common.util.Functions.Function1; +import com.uber.hoodie.common.util.Functions.Function2; +import com.uber.hoodie.common.util.Functions.Function3; +import com.uber.hoodie.common.util.Option; +import com.uber.hoodie.common.util.collection.Pair; +import java.io.Serializable; +import java.util.List; +import java.util.stream.Stream; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +/** + * A file system view which proxies request to a preferred File System View implementation. In case of error, + * flip all subsequent calls to a backup file-system view implementation. + */ +public class PriorityBasedFileSystemViewDelegator implements HoodieView, Serializable { Review comment: The name doesn't seem to do justice to the fact that it implements HoodieView. May be just call is "PriorityBasedFileSystemView" ? I understand this is delegating, may be just mention it in the comments.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
