nsivabalan commented on code in PR #6782:
URL: https://github.com/apache/hudi/pull/6782#discussion_r1072338818
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -255,38 +255,35 @@ public List<Pair<String,
Option<HoodieRecord<HoodieMetadataPayload>>>> getRecord
return result;
}
- private Map<String, Option<HoodieRecord<HoodieMetadataPayload>>>
readLogRecords(HoodieMetadataMergedLogRecordReader logRecordScanner,
+ private Map<String, Option<HoodieRecord<HoodieMetadataPayload>>>
readLogRecords(HoodieMetadataLogRecordReader logRecordReader,
List<String> keys,
boolean fullKey,
List<Long> timings) {
HoodieTimer timer = HoodieTimer.start();
- if (logRecordScanner == null) {
+ if (logRecordReader == null) {
timings.add(timer.endTimer());
return Collections.emptyMap();
}
- String partitionName = logRecordScanner.getPartitionName().get();
+ Map<String, Option<HoodieRecord<HoodieMetadataPayload>>> logRecords = new
HashMap<>(keys.size());
- Map<String, Option<HoodieRecord<HoodieMetadataPayload>>> logRecords = new
HashMap<>();
- if (isFullScanAllowedForPartition(partitionName)) {
Review Comment:
I meant something diff. but I checked the code, we are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
